search

Scratch-Client-4 / client

🖥 The SC4 desktop client. Devlopement currently halted while we work on our mobile client : https://github.com/Scratch-Client-4/mobile
GNU General Public License v3.0
11 stars 1 forks source link

Travis? #6

Closed micahlt closed 4 years ago

micahlt commented 4 years ago

I think at some point we'll need to set up a CI addon or GitHub Action. Anyone got any experience with Travis CI? @Scratch-Client-4/everyone

moeenio commented 4 years ago

I got a little with GitHub Actions, but what do you want to use CI for? Testing, or deploying? We could deploy on Netlify.

micahlt commented 4 years ago

@locness3 probably deploying. I haven't considered deployment options yet.

moeenio commented 4 years ago

Well, no need for a complex ci, just Netlify (or alternative) set up to run parcel build command

Semisol commented 4 years ago

@micahlt I have used GH Actions and Travis before.

micahlt commented 4 years ago

@locness3 Hmm... Netlify's pricing doesn't look good... possibly Heroku or Firebase Apps would be a better choice.

Semisol commented 4 years ago

@micahlt I can host the dev builds.

micahlt commented 4 years ago

Do you host your own servers?

On Apr 7 2020, at 8:30 am, Smiley notifications@github.com wrote:

@micahlt (https://link.getmailspring.com/link/368144D6-A578-4AFE-A3F4-4193778D36F0@getmailspring.com/0?redirect=https%3A%2F%2Fgithub.com%2Fmicahlt&recipient=cmVwbHkrQUczM0hLTk5BWERST0UzMkRVTEk3SE40VEJRVlRFVkJOSEhDSEJBVjZFQHJlcGx5LmdpdGh1Yi5jb20%3D) I can host the dev builds. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/368144D6-A578-4AFE-A3F4-4193778D36F0@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2FScratch-Client-4%2Fclient%2Fissues%2F6%23issuecomment-610387445&recipient=cmVwbHkrQUczM0hLTk5BWERST0UzMkRVTEk3SE40VEJRVlRFVkJOSEhDSEJBVjZFQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe (https://link.getmailspring.com/link/368144D6-A578-4AFE-A3F4-4193778D36F0@getmailspring.com/2?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAG33HKNMRNI4H2SLNDM7TNTRLMTFTANCNFSM4MDDKXVA&recipient=cmVwbHkrQUczM0hLTk5BWERST0UzMkRVTEk3SE40VEJRVlRFVkJOSEhDSEJBVjZFQHJlcGx5LmdpdGh1Yi5jb20%3D).

Semisol commented 4 years ago

Yes.

Semisol commented 4 years ago

I can't IP-Expose them but I could use ngrok or a small Google Cloud machine to expose them to the public.

micahlt commented 4 years ago

Interesting. We could use a subdomain of mine (https://dev.sc4.micahlindley.com) to access it. I'm considering purchasing https://sc4.app/ (https://link.getmailspring.com/link/D5AF8DD8-C7CD-4ED1-9A54-77EAAF836EFF@getmailspring.com/0?redirect=https%3A%2F%2Fsc4.app%2F&recipient=cmVwbHkrQUczM0hLSzdOTEVYVFpRWElXVjdaSlY0VEJRM1hFVkJOSEhDSEJBVjZFQHJlcGx5LmdpdGh1Yi5jb20%3D) when we go live. On Apr 7 2020, at 8:31 am, Smiley notifications@github.com wrote:

Yes. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub (https://link.getmailspring.com/link/D5AF8DD8-C7CD-4ED1-9A54-77EAAF836EFF@getmailspring.com/1?redirect=https%3A%2F%2Fgithub.com%2FScratch-Client-4%2Fclient%2Fissues%2F6%23issuecomment-610388308&recipient=cmVwbHkrQUczM0hLSzdOTEVYVFpRWElXVjdaSlY0VEJRM1hFVkJOSEhDSEJBVjZFQHJlcGx5LmdpdGh1Yi5jb20%3D), or unsubscribe (https://link.getmailspring.com/link/D5AF8DD8-C7CD-4ED1-9A54-77EAAF836EFF@getmailspring.com/2?redirect=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAG33HKPCST7PLWTW5MOKZTDRLMTLXANCNFSM4MDDKXVA&recipient=cmVwbHkrQUczM0hLSzdOTEVYVFpRWElXVjdaSlY0VEJRM1hFVkJOSEhDSEJBVjZFQHJlcGx5LmdpdGh1Yi5jb20%3D).

Semisol commented 4 years ago

Okay.

moeenio commented 4 years ago

@locness3 Hmm... Netlify's pricing doesn't look good... possibly Heroku or Firebase Apps would be a better choice.

Netlify free is sufficient for most tasks tho.

moeenio commented 4 years ago

But yeah, firebase apps or heroku, or now.sh are good too

bryn-trys commented 4 years ago

I have used Netlify in the past, it's okay. We should look into other options as well.

micahlt commented 4 years ago

@locness3 @smileycreations15 @Mai-Trys I took some liberties and went ahead and deployed the alpha to Firebase: https://scratch-client-4.web.app/

bryn-trys commented 4 years ago

@micahlt Sounds good.

ethanhanderson commented 4 years ago

Some really quick comparison of hosting services similar to Now.sh (my personal preference) show that Netlify and Heroku are very similar in pricing.

If we were to use one of these services, it'd be easiest to simply have one of us to link the service to the main repository and then we'd be set.

Since all 3 of these services have continuous deployment, and Heroku and Now have git integration, we would need to make a development branch so we can choose what commits actually get deployed to the production site.

moeenio commented 4 years ago

If we were to use one of these services, it'd be easiest to simply have one of us to link the service to the main repository and then we'd be set.

I guess this is the idea of using CI

micahlt commented 4 years ago

@Hexsphere and I have decided that manual deployment is the best option right now. There's a possibility of moving to continuous deployment in the future, but currently to avoid having to set up another branch, a CI tool, and permissions, we're going to be manually deploying individual feature releases on Firebase.

moeenio commented 4 years ago

Why not deploy master via CI?

moeenio commented 4 years ago

At least for now And what "permissions" do you mean?

micahlt commented 4 years ago

We'd have to re-host the client somewhere that supports integration such as Heroku but doesn't allow free custom domains like Firebase does. We'd also have to set up a CI tool and make sure that only specific people could push to the master branch.

moeenio commented 4 years ago

If I'm not wrong, Netlify offers free custom domains, and it also sets up CI by itself when you connect the repository. As for permissions, I'm unsure how to do this.

moeenio commented 4 years ago

People here accepted the policies, so I think they won't push anything to master, and even if they do, it's not hard to revert a git commit (as soon as they don't force-push or whatever). If you really want to protect access to the master branch, go to the repository's Settings > Branch protection > Add rule > set master as branch pattern > check Restrict who can push to matching rules and select people