search

Scratch-Client-4 / itchy-cordova

📱 Cordova-based mobile client for Scratch
17 stars 4 forks source link

Fix dot-prop vulnerability #20

Closed micahlt closed 4 years ago

micahlt commented 4 years ago

There's a critical security vulnerability risk with a dependency of Cordova. Just run npm install to check it out. However, we need someone to manually fix it, as npm audit fix claims that there are breaking changes.

moeenio commented 4 years ago

I'm not sure these "breaking changes" would affect us, we're using like 1% of cordova's features

micahlt commented 4 years ago

Hm... and I can always revert if there's an issue, I guess.

moeenio commented 4 years ago

You should just test before pushing, i think you have time to work on that since you're pretty active rn ;)

micahlt commented 4 years ago

I don't actually have time lol, but I'll squeeze it in.

moeenio commented 4 years ago

I assume you have time because you keep on adding new stuff 🙃

micahlt commented 4 years ago

Lol I really shouldn't tho - this issue was fixed in 6c1ebe17d00024b749294f5b69a0c8df80c0543b, by the way.