search

Scratch-Client-4 / itchy-cordova

📱 Cordova-based mobile client for Scratch
17 stars 4 forks source link

Do not include cordova.js in the project files #22

Closed locness3 closed 4 years ago

locness3 commented 4 years ago

I had raised this on our Teams DM, and I'm posting it here so it can get more attention.

We shouldn't include the cordova.js file in our project files. It's a file supposed to be auto-generated by cordova when building the app. It is included here as a "workaround" to make sure Parcel doesn't complain about a non-existent script, but we definitely shouldn't do that.

Looking at https://github.com/parcel-bundler/parcel/issues/2398, we have two possibilities : Either add cordova.js as an entry point or use this plugin to mark external files.

I was unable to get both of those to work, so any help appreciated.

cc @micahlt @Hexsphere

grngxd commented 4 years ago

I'd say plugin

locness3 commented 4 years ago

I also think it's the best solution. Would be appreciated if someone could get it to work.

locness3 commented 4 years ago

Also, please don't 👍 your own messages ;)

micahlt commented 4 years ago

Fixed in 6ae86c4.

locness3 commented 4 years ago

Awesome, congrats Micah!