Scratch-Client-4 / itchy-cordova

📱 Cordova-based mobile client for Scratch
17 stars 4 forks source link

Viewing projects #25

Closed moeenio closed 4 years ago

moeenio commented 4 years ago

Add the ability to view projects (using forkphorus, I'd include its code directly in our thing with a git submodule) and their details and comments. We should also make it so that the projects don't load instantly, the worst thing with scratch's mobile website. Instead, the user would do some kind of interaction before the project loads.

grngxd commented 4 years ago

but, but that was my question :( #24

moeenio commented 4 years ago

I just rephrased it ;)

retronbv commented 4 years ago

using forkphorus

Nonono use turbowarp.org

moeenio commented 4 years ago

Maybe? I'm not sure which one's better

retronbv commented 4 years ago

Fork was made by the same person as turbo turbo is better they said

moeenio commented 4 years ago

we'll see

micahlt commented 4 years ago

@YOYITsM3M8 Currently Forkphorus has better embed options than TurboWarp.

retronbv commented 4 years ago

@YOYITsM3M8 Currently Forkphorus has better embed options than TurboWarp.

Okay, but I would still recommend turbowarp

moeenio commented 4 years ago

:thinking:

micahlt commented 4 years ago

@AyzansAlt It's not relevant - we won't ship a full TurboWarp engine with the app, that'll make it huge.

moeenio commented 4 years ago

I'd argue that embedding TurboWrap would still have it be downloaded to the user's device

grngxd commented 4 years ago

Externally?

moeenio commented 4 years ago

Would still take storage space (at least cache)

Also I think we'll use forkphorus

micahlt commented 4 years ago

@locness3 Honestly, now that I'm investigating, TurboWarp actually is a lot better. It handles graphics a lot better than both Forkphorus and Scratch itself, and its 60FPS feature would be nice to have. TurboWarp also isn't that big of a download. Forkphorus is kinda going out of support now that @GarboMuffin has started building on TurboWarp.

moeenio commented 4 years ago

Okay, we'll use turbowarp

micahlt commented 4 years ago

@locness3 It would be possible to embed Turbowarp without a ton of space. The engine takes up <13MB, so it's not significant.

moeenio commented 4 years ago

k

grngxd commented 4 years ago

@locness3 Honestly, now that I'm investigating, TurboWarp actually is a lot better. It handles graphics a lot better than both Forkphorus and Scratch itself, and its 60FPS feature would be nice to have. TurboWarp also isn't that big of a download. Forkphorus is kinda going out of support now that @GarboMuffin has started building on TurboWarp.

umm what did I say

micahlt commented 4 years ago

@locness3 Can you work on adding TurboWarp in as a submodule?

moeenio commented 4 years ago
git submodule init
# for each repo
git submodule add https://github.com/owner/repo

git commit -m "whatever"
git push
micahlt commented 4 years ago

Huh, okay. But then how do we use the code? I'll have to read up on submodules; I'm not familiar with them.

micahlt commented 4 years ago

This was partially finished in PR #35.

micahlt commented 4 years ago

@locness3 Could I close this?