search

Scratch-Client-4 / itchy-ionic

📱 A mobile app for Scratch
https://itchy.micahlindley.com
23 stars 4 forks source link

[feat] Allow different embed providers #34

Closed micahlt closed 2 years ago

micahlt commented 3 years ago

Currently we utilize Turbowarp for actually rendering Scratch projects, which provides its own cloud variable server and Javascript-compiling engine rather than running in a VM like Scratch (.mit.edu) does. However, it might be nice to allow users a few different embed options like the official Scratch embeds, Turbowarp, or others.

moeenio commented 2 years ago

micahlt commented 2 years ago

This is actually something that would be super easy to add. I'll work on it this afternoon.

micahlt commented 2 years ago

I've run into a styling issue - while TurboWarp embeds are transparent, Scratch embeds have a white background that can't be changed.

moeenio commented 2 years ago

Yes.

micahlt commented 2 years ago

It's worth noting that this issue and #35 are mutually exclusive - if we integrate TurboWarp's engine within the app, switching the embed provider would be extremely difficult. At this point, TurboWarp is stable enough that I'm not sure using the vanilla Scratch embed is beneficial at all. Thoughts @locness3?

moeenio commented 2 years ago

if we integrate TurboWarp's engine within the app, switching the embed provider would be extremely difficult.

nah, turbowarp could be integrated as a separate web page loaded in an iframe, that would be part of the application bundle instead of being loaded from the internet

micahlt commented 2 years ago

Ah, I see. Will that not drastically increase Itchy's download size?

moeenio commented 2 years ago

increase Itchy's download size

Who cares?

For a real answer, it will probably make it the current size + what you download when you visit the TurboWarp website (or use the iframe) - except you likely won't download it as often.

moeenio commented 2 years ago

(The source code download might get much heavier though - but if you can run Android Studio...)

micahlt commented 2 years ago

I personally will be fine - my PC is more than equipped to handle it. So it does look like this is feasible, but still not a massive benefit at the moment so we'll keep it in the backlog.

micahlt commented 2 years ago

As there are no benefits to this and it increases the complexity of the app, I'm going to go ahead and close this. If we get feature requests for this then I might re-open it.