Open micahlt opened 2 years ago
Did not read much of the guidelines but:
Use FABs for primary, positive actions.
I believe showing comments does not really count as an action, and opening in browser is not a primary one.
Hmm... in my usage of Itchy, I tend to use the "Open in Browser" button a lot - any time I desire to add a comment. What does your usage generally look like?
Here is how my usage looks like :
Jokes aside, as much as you may be using it now, it will not have to be a primary action when more features are implemented.
Context: see https://github.com/Scratch-Client-4/itchy-ionic/pull/46#issuecomment-1053728195
Lots of Android apps place options like "Open in Browser" and "Share" in the top right of the title bar. At the moment, we're placing "Open in Browser" under a FAB along with the "Comments" button on both the user and project pages. This is in accordance with the Material Design guidelines here. Sharing (only on project pages at the moment) is placed in the chip row under the project embed.
The question is how should these icons be placed - for familiarity or ergonomics? The title bar may feel more familiar to some users. Ergonomically, it's easier to reach under a FAB. Either of these is technically correct according to the MD guidelines - we just have to figure out which one is better for us.