search

Scratch-Client-4 / landing

🌎 The landing page for Itchy
http://itchy.micahlindley.com/
2 stars 3 forks source link

New Features: Added Footer Section and Our Team Section #21

Closed rudrathegreat closed 3 years ago

rudrathegreat commented 4 years ago

As @ConvexPolygon was having some trouble trying to produce results in the time he would finish it in, I decided to help out. I designed a simple Our Team Section, and I also designed a footer. All features and enhancements are below -

Let me know your thoughts. Again, similar to the Latest News Section, there are only placeholders for both the footer and the Meet Our Team Section. I recommend that everyone adds their name, one-word description and contacts. Also add your logo/photo to replace the sc4 logo. As for the footer, there is a section called the 'Latest Updates' which briefly mentions the news as well. Also put relevant info there. Again, let me know your thoughts ASAP and put it in the develop branch until NO placholders remain and the site is filled with working links.

rudrathegreat commented 4 years ago

@micahlt @githubfan pls check this out!

micahlt commented 4 years ago

@rudrathegreat I'll review this ASAP.

locness3 commented 4 years ago

The user links in the "meet the team" section are unclickable on an actual phone IMG_1554

rudrathegreat commented 4 years ago

@locness3 the links don't work because I have not added any links yet, that is why I told the reviewers to take note to merge it into the develop branch, because I want everyone to add their own social media links, their name, their tagline, etc. And I believe that the website should be based off viewport width as it is independent to screen size (1080p, 4k, etc.), pixel density, etc. making it more responsive on a variety of devices.

locness3 commented 4 years ago

I know the user links are placeholders, but look at their size, proportionally to my finger (I sent a picture, have you seen it?) @rudrathegreat

rudrathegreat commented 4 years ago

I've seen that and I am making changes rn btw i was at school!

rudrathegreat commented 4 years ago

yeah they look really tiny, i think instead we have a sort of onclick effect in which there is layer which comes on top of the card, showing the contact links, that should do the trick. Requires javascript though, working on it rn!

locness3 commented 4 years ago

I think the best is to stack them on mobile.

rudrathegreat commented 4 years ago

Ok, made some changes, hopefully this can be merged to the main branch

locness3 commented 4 years ago

"documentation" label? 🤔

rudrathegreat commented 4 years ago

oh and btw @neevjew is working on the click effect I described above (that's going to fix the tiny buttons problem for mobile)

locness3 commented 4 years ago

Why is there a "documentation" label?

micahlt commented 3 years ago

Is this ready for merge?

locness3 commented 3 years ago

I requested changes.

rudrathegreat commented 3 years ago

I left the org. Sorry couldn't get time to work on anything

locness3 commented 3 years ago

Scratch Client 4 really isnt anything anymore. Thanks for trying to help.