ScratchAddons / ScratchAddons

All-in-one browser extension for Scratch.
https://scratchaddons.com
GNU General Public License v3.0
716 stars 367 forks source link

Hide project stats: Placement of buttons differs on different projects #3376

Closed just-a-hriday closed 2 years ago

just-a-hriday commented 3 years ago

Description

The spacing between the love and favourite buttons differs on different projects.

Repoduction steps

  1. Apply the settings json file at the bottom.
  2. Go to the first project in the Recent section of the Explore tab.
  3. Go to the most loved and faved project (aka Paper Minecraft).
  4. Compare the spacing between the love and favourite buttons and the view count of both projects.

Expectation

The love and fave buttons, and the remix and view counts (if enabled) should all be right next to each other.

Reality

The spacing between the buttons is completely different on different projects. I believe this is because the spacing between them remains the same as if the love and fave counts were still visible - which is futher proved by the fact that Paper Minecraft has way more spacing than any other project, and the most recently shared project (found in the Recent section of the Explore tab) does not have much.

Screenshots

image image

Taken from the first two projects I saw, Goodnight Bubbles and Honeybee True or False respectively.

Environment

lisa-wolfgang commented 3 years ago

This is because the addon creator (9gr) used the visibility CSS attribute, which keeps spacing intact, instead of the display attribute that removes the spacing.

I'm currently working on a fix for this that replaces the stat text with a love/favorite text label.

FunctionalMetatable commented 3 years ago

This is because the addon creator (9gr) used the visibility CSS attribute, which keeps spacing intact, instead of the display attribute that removes the spacing.

When I created this, I tried using display: none; but sadly it affected the ::before part (which kept the buttons intact) so I just used visibillity: visible; (which worked).