ScratchAddons / ScratchAddons

All-in-one browser extension for Scratch.
https://scratchaddons.com
GNU General Public License v3.0
715 stars 366 forks source link

Better 3.0 Studios addon #3816

Open PurpleZen opened 2 years ago

PurpleZen commented 2 years ago

Hello! So I have a bookmarklet that makes the studio page look better. I was suggested (@DogCatPuppyLover) that I make this into a Scratch Addon, as it would make it easier for users to use.

I am aware that there is the Old Studios addon, but I was curious if implementing this into Scratch Addons would be possible too? There would be some stuff that would need to be changed to fit properly in Addons, and I feel like there's a lot of stuff that could probably be enhanced (i.e. using JS to actually reposition stuff instead of just using CSS), though my knowledge of doing so is quite limited.

So, would this be something that could be collaborated on? I'm not well versed in how to create an addon for SA, so if there's any interest in helping out, that would be cool! Thanks! :D

You can see some screenshots here, if you'd like.

lisa-wolfgang commented 2 years ago

Hi there! We'd be happy to help you convert your bookmarklet into an addon.

To get started, you should take a look at the documentation for creating a new addon: https://scratchaddons.com/docs/develop/getting-started/creating-an-addon/

For assistance beyond that, I'd recommend joining our private development Discord server. It's "private" in that World_Languages manually grants channel access to each person who joins the server. The invite link is at the top of the README. If you'd prefer to not use Discord, you can also use the Discussions tab.

webdev03 commented 2 years ago

Your bookmarklet is really cool! I think that the only problem with it is getting it to work with the other studio one... (https://user-images.githubusercontent.com/75148774/142073204-3cf795e5-f535-4b86-a1d6-4016a09ebc39.png) The leave studio button has an exclamation mark on it..

cobaltt7 commented 2 years ago

Can you show a picture of what the bookmarklet does?

Also, using CSS over JS is recommended wherever possible.


From: Leo @.> Sent: Tuesday, November 16, 2021 2:07:32 PM To: ScratchAddons/ScratchAddons @.> Cc: Subscribed @.***> Subject: [ScratchAddons/ScratchAddons] Better 3.0 Studios addon (Issue #3816)

Hello! So I have a bookmarklethttps://github.com/LegoManiac04/legomaniac04.github.io/blob/main/better-studios/full-fix.js that makes the studio page look better. I was suggestedhttps://github.com/LegoManiac04/legomaniac04.github.io/discussions/22#discussion-3689149 @.***https://github.com/DogCatPuppyLover) that I make this into a Scratch Addon, as it would make it easier for users to use.

I am aware that there is the Old Studios addon, but I was curious if implementing this into Scratch Addons would be possible too? There would be some stuff that would need to be changed to fit properly in Addons, and I feel like there's a lot of stuff that could probably be enhanced (i.e. using JS to actually reposition stuff instead of just using CSS), though my knowledge of doing so is quite limited.

So, would this be something that could be collaborated on? I'm not well versed in how to create an addon for SA, so if there's any interest in helping out, that would be cool! Thanks! :D

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/ScratchAddons/ScratchAddons/issues/3816, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOT5DEQCJ4PJXCAMRMGPDBTUMK2YJANCNFSM5IFEWPXA.

lisa-wolfgang commented 2 years ago

Can you show a picture of what the bookmarklet does? Also, using CSS over JS is recommended wherever possible.

The issue author included a link to a project with numerous screenshots of what the bookmarklet does.

WorldLanguages commented 2 years ago

Anything that can be done with just CSS, should be done with just CSS Converting it to an addon should be easy. I'm not sure if we can add every userstyle/theme that's submitted to us, tho. The more themes we have, the harder is to make all of them compatible between each other. @mxmou What do you think?

PurpleZen commented 2 years ago

@lisa-wolfgang Awesome, thank you! @webdev03 I've noticed that too, though as long as is it styles the Leave Studio button, it should work? @WorldLanguages That makes sense, thanks!

lisa-wolfgang commented 2 years ago

If we're worried about compatibility, the ideal solution is to take only the CSS that doesn't conflict with dark-www and then add this as an additional option to the studio layout addon, similar to what editor-theme3 was like before we transitioned to granular control and presets.

mxmou commented 2 years ago

This could certainly be a good addition! I like how it simplifies the design.

Theme compatibility is important and adding more themes does make it more difficult, but dark-www compatibility will be much easier if #3710 gets merged.

I don't think this should be a single addon though. It does multiple different things:

PurpleZen commented 2 years ago
  • A simplified design: white background, gray description box, flat unselected tabs, projects, comments, and activity items not being boxes and only having a line at the bottom. This seems to be the most important part of the bookmarklet. It could be a theme for all scratch-www pages, not just studios.

  • Smaller buttons: this could also be a separate addon for all 3.0 pages. Scratch's buttons are really big, so people might want smaller ones everywhere, but I don't think they need to be very small either: 14px text with 8px vertical padding would probably be a better combination than what the bookmarklet currently does, and it could be customizable.

  • Four projects per row: we already have an addon that can do that, although it only changes the size of individual project tiles, not the width of the project grid.

  • Moving the studio title and statistics: this could be an option in "old studio layout" called something like "minimal change" because it keeps most of the scratch-www layout.

I've locally forked SA, and began implementing it this way, thanks! :D