search

ScratchAddons / ScratchAddons

All-in-one browser extension for Scratch.
https://scratchaddons.com
GNU General Public License v3.0
711 stars 367 forks source link

columns and custom-block-shape conflict with each other when seeing inside #4050

Open Samq64 opened 2 years ago

Samq64 commented 2 years ago

Description

When clicking see inside from the project page, if both custom-block-shape and columns are enabled both addons don't load properly. Reloading page from the the editor fixes this.

Reproduction steps

  1. Enable columns
  2. Enable custom-block-shape
  3. Open a project page
  4. Click see inside

Expected behaviour

columns and custom-block-shape should load normally.

Actual behaviour

custom-block-shape doesn't work at all and columns loads partially causing the add extension button to overlap the motion and sensing categories and extra space to the left of the block palette. Extensions also don't show up.

Screenshots

After Clicking see inside:

image

After reloading the page from the editor: image

Note: I scrolled to the top of the motion category and used the same project for both screenshots.

Environment

Additional Context

After reloading from the editor I can't seem to reproduce with the same project by toggling between the editor and project page or after reloading from the project page.

mxmou commented 2 years ago

Cannot reproduce.

LercDsgn commented 2 years ago

Couldn't reproduce, reloaded; reproduced for a moment, but it got back working right after.

LercDsgn commented 2 years ago

Can you provide your settings for the custom-block-shape addon? Maybe that's what causes it.

Samq64 commented 2 years ago

The padding is set to 80%. The other two are set to 100%.

Also, I can't reproduce consistently either (anymore)

Samq64 commented 2 years ago

This also messes up a bunch of other addons like editor-searchable-dropdowns and editor-dark-mode

WorldLanguages commented 2 years ago

Is it possible you were running other extensions on scratch.mit.edu?

Samq64 commented 2 years ago

Is it possible you were running other extensions on scratch.mit.edu?

Just the DuckDuckGo extension.

WorldLanguages commented 2 years ago

Hmm, then this might be a race condition

elFrancisco2000 commented 11 months ago

I Have Other Addons Activated But It doesn´t work on my pc, i have windows 10 and i´m using opera GX but i think it also Happens On Chrome