ScratchAddons / ScratchAddons

All-in-one browser extension for Scratch.
https://scratchaddons.com
GNU General Public License v3.0
716 stars 367 forks source link

Consider turbowarp-player in animated-thumb's "use stage" #5259

Open fractioneater opened 2 years ago

fractioneater commented 2 years ago

Why this would be helpful/solve a problem

When I try to set the thumbnail and I have turbowarp-player enabled, if I click 'use stage,' it shows what the scratch player shows instead of the turbowarp player.

What this change does

This change would make SA detect whether the active player is turbowarp or scratch, and use that for the image in the thumbnail menu.

Possible alternatives

It works to take a screenshot and set the thumbnail to the screenshot you just took, but it's one step more when it shouldn't be too hard to use the stage.

Demonstration(s) and additional context

Screen recording 2022-10-24 15.37.37.webm

mxmou commented 2 years ago

I'm not sure if this is possible - if it isn't, the use stage option should probably be hidden if the TurboWarp player is used.

WorldLanguages commented 2 years ago

This is not possible because we don't have host permissions for turbowarp.org and we can't read a cross-origin iframe.

Changing the issue to hiding or somehow changing the "use stage" button while turbowarp iframe is on.

fractioneater commented 2 years ago

That makes sense. If the "use stage" button were gray, and there was a message at the bottom saying something along the lines of "The Turbowarp player cannot be used to set the thumbnail, switch to Scratch or upload an image," that would be better than what it is currently, and it's simple to implement.

DNin01 commented 1 year ago

I think graying out the "Set Thumbnail" button could also be a good solution.

WorldLanguages commented 1 year ago

I think graying out the "Set Thumbnail" button could also be a good solution.

You mean the "use stage" button?

DNin01 commented 1 year ago

I think graying out the "Set Thumbnail" button could also be a good solution.

You mean the "use stage" button?

Either one, I guess.