search

ScratchAddons / ScratchAddons

All-in-one browser extension for Scratch.
https://scratchaddons.com
GNU General Public License v3.0
711 stars 367 forks source link

Add vanilla buttons to forum-toolbar settings #6059

Open mybearworld opened 1 year ago

mybearworld commented 1 year ago

Why this would be helpful

A lot of people probably don't use some buttons of the forum toolbar. They may want to get rid of them.

My suggestion

Add options to forum-toolbar to remove the vanilla buttons as well.

Possible alternatives

We could create a separate addon instead, but this would make more sense.

Additional context

No response

WorldLanguages commented 1 year ago

Sounds like over-customization to me

mybearworld commented 1 year ago

Sounds like over-customization to me

I wouldn't say so. I don't think I'm alone in wanting to remove the Clean button, for example.

WorldLanguages commented 1 year ago

Find someone who really wants to remove the Clean button but doesn't know about AdBlock's "hide something on this page" feature or any other alternative way to hide it 🤔

mybearworld commented 1 year ago

Find someone who really wants to remove the Clean button but doesn't know about AdBlock's "hide something on this page" feature or any other alternative way to hide it 🤔

With the same logic, hide-delete-button, hide-project-stats , hide-signatures and hide-stage could be removed as well.

WorldLanguages commented 1 year ago

I wouldn't say those are directly comparable - all but the last you mentioned hide elements that may appear multiple times per page. And I don't need to elaborate about hide-stage, right? You can't achieve the same UX with AdBlock, and hiding the stage with display:none causes crashes.

mybearworld commented 1 year ago

Right, then it's only hide-signatures (blocking scratch.mit.edu##.postsignature is not difficult).

WorldLanguages commented 1 year ago

That addon idea is completely obvious and it adds a toggle button which requires JavaScript ¯\(ツ)/¯

BroJac5246 commented 1 year ago

Sounds like over-customization to me

While I do agree it's a good bit of customization, users (including myself) would definitely use this. I never use a lot of the buttons, particularly since keyboard shortcuts exist, and as a result, it is annoying when I actually do have to find a button to use because I have trouble locating it.

WorldLanguages commented 1 year ago

While I do agree it's a good bit of customization, users (including myself) would definitely use this. I never use a lot of the buttons, particularly since keyboard shortcuts exist, and as a result, it is annoying when I actually do have to find a button to use because I have trouble locating it.

How many of the buttons would you hide? Can't you hide them already through other methods?

Samq64 commented 1 year ago

How many of the buttons would you hide? Can't you hide them already through other methods?

I would probably hide the numeric list, user agent, clean and preview (with live preview enabled) buttons.

There are other ways to hide them, but if we have an addon that hides the tutorial button, I think this should exist too. I don't think there's any reason to have the option to hide the first few buttons (bold, italic, underline and strike through) through.

mybearworld commented 1 year ago

Would it be better if there was options for "Formatting", "URL/Images", "Font Size", "Lists", "Other Tags", "Browser/OS", "Scratchblocks", "Clean/Preview" (e.g. the sections) instead of all the buttons?

WorldLanguages commented 1 year ago

That's probably better but "clean" probably deserves its own setting.

mybearworld commented 1 year ago

True, for getting rid of the preview button, forum-live-preview already exists anyways.

Secret-chest commented 1 year ago

I don't think there's any reason to have the option to hide the first few buttons (bold, italic, underline and strike through) through.

I believe otherwise, those are easy to make with keyboard shortcuts.

BroJac5246 commented 1 year ago

Would it be better if there was options for "Formatting", "URL/Images", "Font Size", "Lists", "Other Tags", "Browser/OS", "Scratchblocks", "Clean/Preview" (e.g. the sections) instead of all the buttons?

"URL" and "Images" should be separate settings because the former is easily and habitually done through a keyboard shortcut, so people will want to hide the "URL" button but not the "Images" button.

WorldLanguages commented 1 year ago

I forgot Forums image uploader adds its own button, right?

CST1229 commented 1 year ago

I forgot Forums image uploader adds its own button, right?

It does.

DNin01 commented 1 year ago

Is there a good enough reason to hide these useful features? How many people care about hiding them?

If someone hid buttons they never used before, they also wouldn't have the chance to explore them.

Also, what if a user forgets they hid a button or did so accidentally and then someone else tells them to use one of the hidden buttons?

With the same logic, hide-delete-button, hide-project-stats , hide-signatures and hide-stage could be removed as well.

Hiding signatures can save a lot more time than hiding forum toolbar buttons. Hiding the delete button prevents many accidents while still allowing you to delete through a right-click.

Related comment

BroJac5246 commented 1 year ago

Is there a good enough reason to hide these useful features? How many people care about hiding them?

If someone hid buttons they never used before, they also wouldn't have the chance to explore them.

Also, what if a user forgets they hid a button or did so accidentally and then someone else tells them to use one of the hidden buttons?

With the same logic, hide-delete-button, hide-project-stats , hide-signatures and hide-stage could be removed as well.

Hiding signatures can save a lot more time than hiding forum toolbar buttons. Hiding the delete button prevents many accidents while still allowing you to delete through a right-click.

Related comment

I disagree. All options should be disabled by default, so users will be explicitly opting-out of them. And yes, this does save time because you don't need to search through options you don't need. Beyond that, it also simply declutters the toolbar.

WorldLanguages commented 1 year ago

Related comment

Nice find. One year ago, I commented:

This level of customization (hiding specific, important buttons) can be better customized by users themselves by writing their own userstyles or even using adblocker features that let you hide elements.

I wouldn't consider these forum buttons "important", so if this gets added, I suggest that the number of settings we add stays reasonable, instead of adding one setting for each specific button.