ScratchAddons / website-v2

The website for Scratch Addons. (version 2)
https://scratchaddons.com
GNU General Public License v3.0
51 stars 39 forks source link

Add "export settings" button to unsupported-browser page #418

Closed WorldLanguages closed 8 months ago

WorldLanguages commented 9 months ago

Progress for https://github.com/ScratchAddons/ScratchAddons/issues/6876 (see Add the "export settings" and "view settings as file" buttons to the Unsupported Browser page.)

image

WorldLanguages commented 9 months ago

cc @DNin01 it might be a good opportunity to rephrase things on this page, if we want.

WorldLanguages commented 9 months ago

@Hans5958 Is it easy to exclude this page from Google search results?

BroJac5246 commented 9 months ago

@Hans5958 Is it easy to exclude this page from Google search results?

I'd assume this could be accomplished fairly easily via robots.txt. I'm not entirely sure how we can add that but there might be helpful info here.

WorldLanguages commented 9 months ago

@Hans5958 Is it easy to exclude this page from Google search results?

I forgot meta tags exist.

Hans5958 commented 9 months ago

@Hans5958 Is it easy to exclude this page from Google search results?

You already asked for it years ago, and I have added robots_tag: noindex.

https://github.com/ScratchAddons/website-v2/blob/c09cb1f10ae292fcb60e2398de5d0bd51405b1fe/content/unsupported-browser.html#L4

WorldLanguages commented 9 months ago

@Hans5958 Is it easy to exclude this page from Google search results?

Sorry, I was thinking of excluding /welcome and /farewell. This page has already been noindex-ed for a while as you said. Off-topic then.

WorldLanguages commented 9 months ago

Pending tasks

Samq64 commented 9 months ago

Are there any changes needed on the extension side? I pointed the link to localhost and increased the minimum browser version past the current release but the buttons don't show up.

WorldLanguages commented 9 months ago

Are there any changes needed on the extension side?

Yes. Those come later. If you want the buttons to show up, the easiest way is to un-comment line 3 of unsupported-browser.js

WorldLanguages commented 9 months ago

If the extension opens this page every time the browser is restarted, I would suggest also adding a link to or instructions on how to turn off the Scratch Addons browser extension on this page.

@DNin01 I'm not sure how to add this without filling the whole page. The exact instructions to disable an extension vary browser by browser.

DNin01 commented 9 months ago

If the extension opens this page every time the browser is restarted, I would suggest also adding a link to or instructions on how to turn off the Scratch Addons browser extension on this page.

@DNin01 I'm not sure how to add this without filling the whole page. The exact instructions to disable an extension vary browser by browser.

Then the other options would be to only show this page once and never again or to have an option to remove the extension, calling uninstallSelf():

chrome.management.uninstallSelf({ showConfirmDialog: true });
WorldLanguages commented 9 months ago

I would merge this now, in the future we could add dynamic instructions on how to disable the extension by detecting the browser. We could also make sure this page doesn't open automatically by the extension unless we are sure an update just came out that transformed the extension from supported to unsupported.

Hans5958 commented 9 months ago

Could you give me the latest screenshot?

WorldLanguages commented 8 months ago

Here is an updated screenshot.

image