search

ScratchAddons / website-v2

The website for Scratch Addons. (version 2)
https://scratchaddons.com
GNU General Public License v3.0
49 stars 38 forks source link

Fix .site.IsServer deprecation error #485

Closed Samq64 closed 3 weeks ago

Samq64 commented 3 weeks ago

I thought this was already fixed?

Samq64 commented 3 weeks ago

The Hugo version is too old. Should I update the action or downgrade on my end?

Hans5958 commented 3 weeks ago

I'd rather have the Hugo version updated. Don't worry if it fails here, just in case. If the deployment works on this PR, it would also work on master.

Samq64 commented 3 weeks ago

I'm asking because of

Starting on Hugo 0.120, the minify command works differently to the point that it can't escape quotation marks properly, which makes the feedback system break. This should be investigated further, but this is good enough patch for now.

Hans5958 commented 3 weeks ago

Problem is that v0.120 is been a while. The current version is v0.133 v0.134 v0.133. Something may change. I would test it, or you can test it too.

Hans5958 commented 3 weeks ago

I checked using v0.134 v0.133 and it seems that they have fixed it. You can update it safely.

Samq64 commented 3 weeks ago

You're welcome and I'm a little confused too since the console message said 0.134.