search

ScratchUtilities / gobo.icu

URL Shortener For Scratch
https://gobo.icu
The Unlicense
13 stars 23 forks source link

Setting Display: None Breaks the Animation #51

Closed jamesbmadden closed 5 years ago

jamesbmadden commented 5 years ago

A recent commit added styles to hide the converter page with display: none until the button is pressed. The issue is that the browser (tested in the latest versions of desktop Firefox, Chrome, and Safari) no longer animates the entrance. I'm assuming it's because it doesn't have a frame to animate from, so it just appears. Removing the display: none style fixes the issue.

To Reproduce Steps to reproduce the behavior:

  1. Go to the homepage (gobo.cf)
  2. Click on 'Shorten URL'

Expected behavior After the start page slides out, the converter page slides in.

Actual Behavior The converter page instantly appears in place, as the start page slides out.

Can you create a fix? Remove display: none from the #fillinPage style in files/styles.css.

Additional context The change that caused this bug is meant to fix an issue, so my fix may make that issue come back. I do not know what the issue was, so I can't test my suggested fix for that issue.

Andreto commented 5 years ago

I now used visibility: hidden; instead. This should fix the issue.

sweezyio commented 5 years ago

Has this issue been resolved? If so please close the issue.

jamesbmadden commented 5 years ago

Sorry, yes, I'll close it now