search

ScreamingHawk / android-slideshow

A simple slideshow application for your mobile.
MIT License
43 stars 45 forks source link

Handle NullPointerException in CustomImageStrategy.load #106

Closed ScreamingHawk closed 6 years ago

ScreamingHawk commented 6 years ago 
Caused by: java.lang.NullPointerException: 
  at link.standen.michael.slideshow.strategy.image.CustomImageStrategy.load (CustomImageStrategy.java:74)
  at link.standen.michael.slideshow.ImageActivity.loadImage (ImageActivity.java:506)
  at link.standen.michael.slideshow.ImageActivity.onCreate (ImageActivity.java:304)

I imagine this should be a trivial fix. If anyone wants to pick it up before I get to it, go for it.

ph4k4 commented 6 years ago

Hi @ScreamingHawk , I would like to practice open source android development, is it okay if i work on this issue?

ScreamingHawk commented 6 years ago

Thanks very much @ph4k4 !

Let me know if you have any difficulty setting up the project, or submitting a pull request.

I haven't investigated this issue, so I'm not sure how to replicate it. I'll be happy with a 1 line fix like adding a null check, which should be enough to stop the error.