search

ScreamingHawk / android-slideshow

A simple slideshow application for your mobile.
MIT License
43 stars 45 forks source link

Rotating Phone Restarts Application #114

Closed isreal6ix closed 5 years ago

isreal6ix commented 6 years ago

Expected Behavior

Just like some similar apps, regardless of the orientation, users should be able to use the App without any errors

Actual Behavior

When in a folder of where pictures are stored, and the device orientation goes landscape, it would take users to the root folder and start all over again.....

How to produce the bug

TEST TOOLS

Recording of the bug is showned below......

Watch the video below to see how it behaves....

https://youtu.be/JQQi_rgEZB0


Posted on Utopian.io - Rewarding Open Source Contributors

ScreamingHawk commented 6 years ago

Thanks! I had never noticed this before. It's even more annoying when you've got the auto start setting on.

isreal6ix commented 6 years ago

You're most welcome

SamuelBiros commented 6 years ago

Hey there, it this issue still up for grabs? I would be interested..

ScreamingHawk commented 6 years ago

Hi @SamuelBiros Yes it is! Feel free to pick it up. If you need any help you can drop me a message

SamuelBiros commented 5 years ago

Hello, the problem is solved. I requested a merge.

ScreamingHawk commented 5 years ago

Thanks so much @SamuelBiros

Sorry it took so long to approve this merge request. It's now included and I'll have a release out shortly: https://github.com/ScreamingHawk/android-slideshow/commit/df58fd5aca1004e0e8e4d6692cc0c2d6b1d32378

ScreamingHawk commented 5 years ago

That wasn't shortly at all 😅 I've pushed this through to the beta stream. Will have a play for a while before moving to production. FYI Anyone is able to access the beta stream.