Closed ScreamingHawk closed 6 years ago
Can I work on this?
Absolutely! Thanks so much
Let me know if you've got any questions and I can give you a hand.
Cheers, Michael
On Wed, 15 Aug 2018, 12:02 PM Brandan Lockwood, notifications@github.com wrote:
Can I work on this?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ScreamingHawk/android-slideshow/issues/118#issuecomment-413053521, or mute the thread https://github.com/notifications/unsubscribe-auth/ABZJSFSub4EYmNBBEfwYST2jL6lvBPwfks5uQ2UPgaJpZM4V2cnb .
Hi Michael, At https://github.com/ScreamingHawk/android-slideshow/blob/master/app/src/main/java/link/standen/michael/slideshow/model/FileItem.java#L59 is there reason to compare names versus paths?
Not really.
Originally there was only a single folder to slideshow from, so the path
part of the path
was always the same. This fix should be as easy as changing that line as you've pointed out.
Fixed in #119
The
Play From Here
button currently sorts alphabetically by filename when it should sort alphabetically by path.This should be an easy fix by changing this line: https://github.com/ScreamingHawk/android-slideshow/blob/master/app/src/main/java/link/standen/michael/slideshow/util/FileItemHelper.java#L68
e.g.
Current:
Expected: