ScreamingSandals / ScreamingLib

Cross-platform library for Minecraft development.
Apache License 2.0
29 stars 7 forks source link

Import quickbuy from hypixel #22

Closed ARDragssss closed 1 year ago

ARDragssss commented 1 year ago

its something really simple yet really effective. You can just click on a certain item and your quickbuy from hypixel gets imported.

Another great thing would be to fix the Price: 1 of iron in red glass quickbuy item and make the whole page customizable, just like the hypixel shop.

boiscljo commented 1 year ago

Wrong repo, quickbuy is all SBA and not screaming lib, But if ScreamingLib could make their shop work correctly even without a price that would fix the 1 of iron issue.

ARDragssss commented 1 year ago

i forgot to remove the quickbuy part lol but i posted the same suggestion on sba repo

ARDragssss commented 1 year ago

nvm i forgot to lol

ARDragssss commented 1 year ago

but still about the price, please fix it.

Misat11 commented 1 year ago

Still wrong repo, but can you explain me what happens if there's no price on the glass?

boiscljo commented 1 year ago

Basically quickbuy works by intercepting the display function and replace the item. So to be also able to intercept the "buy" it needs a price otherwise it's a decorative item in the shop (you can't buy without a price, and fhanging the display item won't make it buyable). So quickbuy change the price and item After you you click for buying the dummy item(red glass pane) which can only be done if the dummy item has a price.

Misat11 commented 1 year ago

Yeah, but you have two options: 1) The lore is something done by you, so you can basically end the method earlier for example. 2) For dummx items, there's another event (I think it's called (Post)ClickEvent or ActionEvent or idk, haven't used SI in ages now xdd)