search

ScreamingTaco / inkscape_app_icon_generator

Inkscape extension to generate app icon sizes
GNU General Public License v3.0
23 stars 8 forks source link

Updated to comply with Inkscape 1.0 #3

Closed RonAFGreve closed 2 years ago

RonAFGreve commented 4 years ago

Updated to comply with Inkscape 1.0

zzeroo commented 4 years ago

Dosn't work under Linux :(

@RonAFGreve You've checked many backup files in your git repo. All these ~ files are trash. Create a file called .gitignore with the following content:

# .gitignore
*~

and execute this command in the root of your repo:

git rm --cached *~

Now add .gitignore, commit the changes and push that to your remote branch

git add .gitignore
git commit -a -m "Remove backup files from repo
git push

The pull request has this changes then. But before check if the plugin works on a different workstation. Linux as OS would be nice :)

RonAFGreve commented 4 years ago

Sorry, yes. I followed your procedure and I think they're gone now.

There are three issues (two unresolved).

1 Apparently under linux python somehow has a .0 after the calculated number so add int() arround it.

2 Apparently inkscape's export file has a random number after it /path ../filename.svg. Not sure why they did that. It doesn't stop the export since it assumes svg but causes a warning

3 Apparently export doesn't work at all under linux (I know there was a problem a while ago with the 1.0 version and think it is resolved for windows but not for Linux (I only could download a beta version).

So I think we need to wait until that solve the export.

Regards, Ron

On 2020-08-25 09:58, zzeroo wrote:

Dosn't work under Linux :(

@RonAFGreve https://github.com/RonAFGreve You've checked many backup files in your git repo. All these ~ files are trash. Create a file called |.gitignore| with the following content:

|# .gitignore *~ |

and execute this command in the root of your repo:

git rm --cached*~

Now add .gitignore, commit the changes and push that to your remote branch

git add .gitignore git commit -a -m"Remove backup files from repo git push

The pull request has this changes then. But before check if the plugin works on a different workstation. Linux as OS would be nice :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ScreamingTaco/inkscape_app_icon_generator/pull/3#issuecomment-679868566, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJ77FVW755UK26CWRFIPBTSCNVLHANCNFSM4QJ54YFQ.

ScreamingTaco commented 2 years ago

I believe #5 should address the same issues. Sorry for getting to this so late; I don't know what happened. Feel free to open another PR from the new branch if there's still something you'd like to add. I welcome the help!