search

ScreenPyHQ / screenpy

Screenplay pattern base for Python automated UI test suites.
MIT License
28 stars 4 forks source link

Github action to run `poetry check` #47

Closed bandophahita closed 1 year ago

bandophahita commented 1 year ago

poetry check verifies the toml and lock files are in sync. This would catch any issues where the toml was updated but a new lock wasn't generated.

perrygoy commented 1 year ago

Would this also catch when a new lock should be generated (that is, a dependency was updated within the toml's specified ranges) but wasn't?

bandophahita commented 1 year ago

I believe so. AFAIK, when you run poetry install it performs poetry check first, which was how I was able to see that screenpy-allure was expecting screenpy >4.0. Subsequently, when I tried to run poetry lock it too ran into the same issue until screenpy-allure reqs were updated.

By that nature, I figure if we simply run a check it should at least let us know there is a dependency problem.

bandophahita commented 1 year ago

Fixed in https://github.com/ScreenPyHQ/screenpy/pull/48