Open bandophahita opened 1 year ago
After a quick discussion on Discord, it seems that adding a .describe()
method to return what you actually want to log seems to fix the issue. However!
get_additive_description
lower-cases the first letter of the string returned by .describe()
. Sometimes you might want a capital. How do we handle this?
class SimpleQuestion:
...
def describe() -> str:
return "SimpleQuestion"
Marcel sees if simpleQuestion is equal to True.
Marcel examines SimpleQuestion
=> False
... hoping it's equal to False.
=> <True>
The short answer is See
needs to be told how to use the describe()
from the question rather than utilize get_additive_description
:
actor.will(See(question, resolution).using_describe())
or maybe there could be some way for get_additive_description
to know to skip it's extra processing by setting something on the question?
actor.will(See(question.skipping_additive(), resolution))
I feel like that's giving too much to the Questions or to See
to know how to do; i don't like the bond that creates between them and get_additive_description
.
The answer's gotta be within get_additive_description
somehow... maybe we ask ChatGPT to make our additive string for us. :P
Could get_additive_description
determine if the describe was overridden?
There are a few times where using the output from get_additive_description doesn't fit. It would be good if
See
had an option to bypass usingget_additive_description
when loggingthe method name should be something far sexier than the above