search

Screenly / Anthias

The world's most popular open source digital signage project.
https://anthias.screenly.io
Other
2.52k stars 623 forks source link

`is_active` should be boolean in API docs #2099

Open nicomiguelino opened 1 month ago

nicomiguelino commented 1 month ago

Before

image

After

image

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vpetersson commented 1 month ago

Technically speaking you can't change an API without bumping the version. You'd break every integration this way.

nicomiguelino commented 1 month ago

@vpetersson, good point. Thanks. Because we've changed the 0 or 1 fields to boolean fields, I'll update v1.2 endpoints so that the boolean fields will be 0 or 1 again. I'll create a new API version, v2.0, as those changes will potentially break clients currently using the API.