search

Screenly / Playground

Various examples of how developers can use Screenly and Screenly's API
https://www.screenly.io
MIT License
23 stars 11 forks source link

Fix bugs in clock app #109 #139

Closed salmanfarisvp closed 11 months ago

salmanfarisvp commented 11 months ago

Fixed issue mentioned here https://github.com/Screenly/Playground/issues/109

image

vpetersson commented 11 months ago

Nice one @salmanfarisvp. However, we shouldn't hard code 24h clock. It should be based on the locale.

salmanfarisvp commented 11 months ago

Thanks @vpetersson.

I'll check the that again and update the PR.

salmanfarisvp commented 11 months ago

@vpetersson Can you guide me on how it should be the expected output?

The old momentObject.format('LT') will use 2:30 AM and use the 24-hour when using a non-English locale depending it.

salmanfarisvp commented 11 months ago

This PR closed by discussion with @nicomiguelino , The Issue already solved and feature already implement in https://github.com/Screenly/Playground/pull/121