Closed yashmandi closed 3 weeks ago
@yashmandi Could I get assign on this issue?, I would love to contribute.
As a Mern Stack developer i have great knowledge in authentcation so please assign too me i love to work on this bug.
Hello Scribbie-Notes Team,
My name is Ishan, and I am a 4th-year BTech student with experience in full-stack development. I would love to contribute to your project. Here is my LinkedIn profile: https://www.linkedin.com/in/ishanguptaofficial/.
Could you please assign me to this issue? Looking forward to your response.
Best regards, Ishan
you can work on it @Abhishek332
Thankyou
Hey, @Abhishek332 If you need any help to solve this problem then Message we can work on it together.
is this issue solved? @yashmandi since i could not able to login i not able to implement my issue
Hi Guys, wait for some time, I found the cause, I will be push the fix for it today EOD. Thanks
nice work @Abhishek332 !!
Hi Guys, wait for some time, I found the cause, I will be push the fix for it today EOD. Thanks
hey @yashmandi , can i work on this issue , because of this issue , i can't work on other issues
hey @yashmandi , can i work on this issue , because of this issue , i can't work on other issues
@Abhishek332 is alreay working on this one.
by when can you get it done @Abhishek332 ?
Hi @yashmandi,
I've fixed the issue and am currently doing some testing. While testing, I found a few more bugs and improvements that we can address in the codebase:
Issue Link: #137 PR Link: https://github.com/Scribbie-Notes/notes-app/pull/138
I'm getting a 400 (bad request) error
during login
After successful signup, all subsequent API requests return a 403 error
(seems like the auth token isn’t being passed for some reason – needs troubleshooting).
I haven’t created separate issues for points 2 and 3 yet. I'll verify these further and then create the necessary issues if needed.
Lastly, I’ve set up a Brevo account and created the SMTP API key
for sending emails, but I'm unsure what to add for BREVO_USER
in backend/.env
. Could you please share the correct value so I can fully test the signup flow for points 2 and 3?
Thanks!
by when can you get it done @Abhishek332 ?
@yashmandi ,
Actually some imports are missing that I added in my branch (And somebody already pushed this change in main, I just merge main in my branch)
in the .env you were giving wrong backend URL (http://localhost:5173) instead of (http://localhost:3000). So getting 404 not found in /create-account and /login was solved by this.
Should we close this issue (as fix for it already present in main) and track issue that I mention in previous comment in separate ticket?
https://github.com/user-attachments/assets/ba7d7ab3-0e2c-4474-93be-09a030d5b6fd
So now you are on the main page but you cannot create notes it redirects to the login page right @Abhishek332
Am pretty sure login won't work here you done registration only
Am pretty sure login won't work here you done registration only
Yes, I mentioned the login issue in my second point. There seems to be another problem with the login, which results in a 400 (Bad Request) error. Adding issue link below, could you please assign this issue to me @yashmandi https://github.com/Scribbie-Notes/notes-app/issues/141
Additionally, after registration, all API calls are failing (as noted in my third point). I suspect it might be related to the sendMail process not being completed or verified. I haven't created a ticket for this yet, as it might just be an issue on my end.
@RaiDevX8 Could you help me setup Brevo
for sending email.
I create a account in Brevo.
Create SMTP secret key
But stuck in what value do I need to add in BREVO_USER
in backend/.env
Hi @Abhishek332 Go to SMTP&API Page there you would see a field called login and a email ends with @smtp-brevo.com. Tho i would say not to use brevo as you also have to set up your custom domain to make it work
https://www.youtube.com/watch?v=kTcmbZqNiGw
Please do watch this video to set up a server directly using gmail. It will be easier also verified and your emails won't go to spam. No need to change the code the details will be the same
Hi @yashmandi,
I've fixed the issue and am currently doing some testing. While testing, I found a few more bugs and improvements that we can address in the codebase:
- We're currently tracking a lot of node_modules packages, which shouldn't be tracked. I've already submitted a PR to fix this. Could you please assign this issue to me under the hacktoberfest label and review/merge the PR? This will help new contributors avoid confusion about why they see many file changes, even though /frontend/node_modules is listed in .gitignore.
Issue Link: #137 PR Link: #138
- I'm getting a
400 (bad request) error
during login- After successful signup, all subsequent API requests return a
403 error
(seems like the auth token isn’t being passed for some reason – needs troubleshooting).I haven’t created separate issues for points 2 and 3 yet. I'll verify these further and then create the necessary issues if needed.
Lastly, I’ve set up a Brevo account and created the
SMTP API key
for sending emails, but I'm unsure what to add forBREVO_USER
inbackend/.env
. Could you please share the correct value so I can fully test the signup flow for points 2 and 3?Thanks!
@yashmandi @RaiDevX8 Login issue is fixed, please review and merge it https://github.com/Scribbie-Notes/notes-app/pull/148
https://github.com/user-attachments/assets/3351b9de-0936-4be3-8aea-a3493feebb66
Hi @yashmandi,
I've fixed the issue and am currently doing some testing. While testing, I found a few more bugs and improvements that we can address in the codebase:
- We're currently tracking a lot of node_modules packages, which shouldn't be tracked. I've already submitted a PR to fix this. Could you please assign this issue to me under the hacktoberfest label and review/merge the PR? This will help new contributors avoid confusion about why they see many file changes, even though /frontend/node_modules is listed in .gitignore.
Issue Link: #137 PR Link: #138
- I'm getting a
400 (bad request) error
during login- After successful signup, all subsequent API requests return a
403 error
(seems like the auth token isn’t being passed for some reason – needs troubleshooting).I haven’t created separate issues for points 2 and 3 yet. I'll verify these further and then create the necessary issues if needed.
Lastly, I’ve set up a Brevo account and created the
SMTP API key
for sending emails, but I'm unsure what to add forBREVO_USER
inbackend/.env
. Could you please share the correct value so I can fully test the signup flow for points 2 and 3?Thanks!
@yashmandi 3rd one is also fixed. Could you please assign this issue to me under hacktoberfest
and review and merge it
issue link - https://github.com/Scribbie-Notes/notes-app/issues/149
Pr Link: https://github.com/Scribbie-Notes/notes-app/pull/150
Hi @Abhishek332 Go to SMTP&API Page there you would see a field called login and a email ends with @smtp-brevo.com. Tho i would say not to use brevo as you also have to set up your custom domain to make it work
https://www.youtube.com/watch?v=kTcmbZqNiGw
Please do watch this video to set up a server directly using gmail. It will be easier also verified and your emails won't go to spam. No need to change the code the details will be the same
Sure, @tanish35 I will definately check it out. Thankyou
Nice job @Abhishek332
@yashmandi This issue can be closed, as all the sub issues I mention in this issue is fixed.
steps to reproduce error: try to signup or login, and open console, you'll get the error description in inspect section.
*important: after fixing the issue, kindly attach the screenrecording of the solution