Fix sign output in number padding

[spbnick]

@sabbaka, does this look right to you?

[sabbaka]

We may use something like Moment.js to handle everything related to time and date.

[spbnick]

Sure, but we aren't yet, and we shouldn't add dependencies too hastily. Cockpit probably has something already.

[sabbaka]

It's there already and also as a dependency for date time picker.

On Mon, Sep 18, 2017 at 7:41 PM, Nikolai Kondrashov < notifications@github.com> wrote:

Sure, but we aren't yet, and we shouldn't add dependencies too hastily. Cockpit probably has something already.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Scribery/cockpit/pull/34#issuecomment-330298588, or mute the thread https://github.com/notifications/unsubscribe-auth/AFTQ5ZfRDD5RcYTlE4jpgEV4e1sHklpMks5sjqtBgaJpZM4PbPeN .

-- Kyrylo Gliebov Software Engineer Red Hat Czech

[spbnick]

Nice :) Feel free to fix this by switching over to it then :)

[sabbaka]

moment.js:737 Deprecation warning: moment construction falls back to js Date. This is discouraged and will be removed in upcoming major release. Please refer to https://github.com/moment/moment/issues/1407 for more info.

[sabbaka]

Will do this, also related to check in datetimepicker.

[spbnick]

Could you please convert this into an appropriate issue and close?

[sabbaka]

39 issue created.

[sabbaka]

Just one quick question - but why did you bother to change "a" to "i" - because there is no difference or this is an actual reason? :)

[spbnick]

Because i can be negative, a can't.

[sabbaka]

It's quite interesting, I have just tried both a and i and compared to output of moment.js and only two dates matched, others have difference in seconds.

[sabbaka]

[spbnick]

What is the code producing this?

[sabbaka]

    let formatDateTime = function (ms) {
        let d = new Date(ms);
        let test1 = moment(d).format('YYYY-MM-DD HH:mm:SS');
        let test2 = (
            padInt(d.getFullYear(), 4) + '-' +
            padInt(d.getMonth() + 1, 2) + '-' +
            padInt(d.getDate(), 2) + ' ' +
            padInt(d.getHours(), 2) + ':' +
            padInt(d.getMinutes(), 2) + ':' +
            padInt(d.getSeconds(), 2)
        );
        if(test1 == test2) {
            console.log(test1 + test2 + 'true');
        }
        else {
            console.log(test1 + test2);
        }
    };

[spbnick]

Can you make a third string here, just pasting the parts together without padInt, and outputting them? Please also add spaces between output strings.

[sabbaka]

        let d = new Date(ms);
        let test1 = moment(ms).format('YYYY-MM-DD HH:mm:SS');
        let test2 = (
            padInt(d.getFullYear(), 4) + '-' +
            padInt(d.getMonth() + 1, 2) + '-' +
            padInt(d.getDate(), 2) + ' ' +
            padInt(d.getHours(), 2) + ':' +
            padInt(d.getMinutes(), 2) + ':' +
            padInt(d.getSeconds(), 2)
        );
        let test3 = (
            d.getFullYear() + '-' +
            d.getMonth() + 1 + '-' +
            d.getDate() + ' ' +
            d.getHours() + ':' +
            d.getMinutes() + ':' +
            d.getSeconds()
        );
        if(test1 == test2) {
            console.log(test1 + ' ' + test2 + ' ' + test3 + ' true');
        }
        else {
            console.log(test1 + ' ' + test2  + ' ' + test3 );
        }

[sabbaka]

Sorry, my fault, I used wrong parameter for moment for seconds. Arghh

[sabbaka]

It was SS - for fractional seconds and for 00 seconds should be only ss.

[spbnick]

I see, it's OK :)

[spbnick]

@sabbaka, do you think we can merge this, since we decided against using a library?

[spbnick]

Thanks, merged!