search

Scribery / tlog

Terminal I/O logger
http://scribery.github.io/tlog/
GNU General Public License v2.0
310 stars 52 forks source link

tlog not working when auditd is disabled, and there's no /proc/PID/sessionid #353

Open haiwu opened 1 year ago

haiwu commented 1 year ago

tlog not working when auditd is disabled, and there's no /proc/self/sessionid. How to ensure tlog would work when auditd is disabled? There's an existing issue here "https://github.com/Scribery/tlog/pull/264", where it suggested using 'getsid(0)', and it seems to work in Linux, where calling 'getsid(0)' would get the interactive ssh session's BASH pid (if the logged in user using BASH shell), which would stay the same during the whole interactive session.

What's the concern of just using getsid(0) (instead of using /proc/self/sessionid) in case auditd being already disabled? pid reaching PID_MAX and wraps around?

haiwu commented 1 year ago

another way is to use systemd $XDG_SESSION_ID, or call 'sd_pid_get_session(my_pid, &session)', which would grab something from systemd, similar to /proc/self/sesionid, whose value would show up in the same position of 'loginctl session-status' output.

justin-stephenson commented 1 year ago

Using a systemd login-related session ID as fallback for the session field if /proc/self/sessionID is unavailable seems reasonable to me, the downside being it would not help for systems which are not using systemd.

haiwu commented 1 year ago

At least it would help out those folks working with systemd-enabled Linux hosts where auditd is disabled.