ScrimbaBootcamp / progress-tracker

Bootcamp students will contribute to this open source project, where we will build a progress tracker to keep up with activity and accomplishments in the Scrimba bootcamp.
https://bootcamp-progress-tracker.netlify.app
MIT License
5 stars 20 forks source link

Added hover effect on nav links #106

Closed Diegoireland1975 closed 3 months ago

Diegoireland1975 commented 3 months ago

added hover effect on links, they will change color and background color, added transition as well"

netlify[bot] commented 3 months ago

Deploy Preview for bootcamp-progress-tracker ready!

Name Link
Latest commit 2071ea205221b095e99f1caad5f91e02d73ba6c9
Latest deploy log https://app.netlify.com/sites/bootcamp-progress-tracker/deploys/66b87c184aba3e0008e19ca8
Deploy Preview https://deploy-preview-106--bootcamp-progress-tracker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Diegoireland1975 commented 3 months ago

the hover effect is in the links in the nav items, I added a background color and they should change the text color as well

michaella23 commented 3 months ago

@Diegoireland1975 I have looked a few times through the code that is found in the 'Files Changed' tab, and I don't see a background color, text color or hover effect for any nav items. I'm sorry. Are you sure. you committed and synced all of your changes?

Screenshot 2024-08-10 at 12 19 48 PM
Diegoireland1975 commented 3 months ago

@michaella23 Hi Yes I committed the changes. If it's not showing maybe I did something wrong when I created a pull request. I will review the code. Could I create another pull request?

michaella23 commented 3 months ago

Could I create another pull request? @Diegoireland1975 yes of course! But you may not need to... I think if you stage and commit the new changes, and then sync those changes it will show up on this PR. Take a look and see.

I went and looked at your fork of the project and I see two different commits - one has styles on the nav elements, but the other one removes the styles from those elements

Diegoireland1975 commented 3 months ago

@michaella23 I tried to push the commit again, now they appear to be in file changed