search

ScrimbaBootcamp / progress-tracker

Bootcamp students will contribute to this open source project, where we will build a progress tracker to keep up with activity and accomplishments in the Scrimba bootcamp.
https://bootcamp-progress-tracker.netlify.app
MIT License
5 stars 20 forks source link

Read me - links corrected #69

Closed eram23 closed 3 months ago

eram23 commented 3 months ago

Fixed the link that was not working (code of conduct).

netlify[bot] commented 3 months ago

Deploy Preview for bootcamp-progress-tracker ready!

Name Link
Latest commit 4c7312b460f6cce886f73ab5c302e2b9e2c07929
Latest deploy log https://app.netlify.com/sites/bootcamp-progress-tracker/deploys/66889ac6e2f2ff00083c656a
Deploy Preview https://deploy-preview-69--bootcamp-progress-tracker.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

michaella23 commented 3 months ago

Oh! Can you also look at line 6 in the README and check if all of those links are working? @eram23

eram23 commented 3 months ago

Hi @michaella23 I double checked the links and made sure they are correct I just need to sync my changes.

And will requesting the new changes from main - git pull upstream main erase any of the progress I have made on my local version?

michaella23 commented 3 months ago

This PR is also showing the changes you made to index.html. I am going to go ahead and merge, but it can be a good practice to commit and push changes corresponding to an issue in one PR and then commit and push the other changes separately. You may still be working on those issues - #23 and #24... Let me know though!

eram23 commented 3 months ago

All done with issues #23 and #24 ! Should I go ahead and delete my read-me branch?

michaella23 commented 3 months ago

You can, yes. @eram23