search

Scripler / scripler

The Scripler web application source code repository
Do What The F*ck You Want To Public License
5 stars 1 forks source link

MVP Reader - Epubjs #964

Closed allanmc closed 9 years ago

allanmc commented 9 years ago

@mortengf Please review.

@osj2507 I included some dummy GUI for the publish funcitonality so you can see how to comunnicate with the backend. Please remove ugly code when doing your changes :) E.g. pay attention to the fact that you need to call compilebefore publish - just as you do when downloading the epub.

osj2507 commented 9 years ago

@allanmc Thank you Allan that was nice of you, in the UI there is an update functionality, would you just run the publish again on that or what do you suggest?

allanmc commented 9 years ago

@osj2507 Yes, "update" is the same as a "publish" again. I just call it "re-publish" in my dummy GUI. On the returned object you'll get both a created and a modified date. On the first publish they will have the same value, but after that created will be fixed, and only modified will be updated.

allanmc commented 9 years ago

@mortengf Implemented review comments. Ready for re-review!

mortengf commented 9 years ago

I am happy: approved! :palm_tree:

Please inform Ole when he can merge your changes (in beta1) into his own branch.