search

ScriptFUSION / Pip

🖨 Immediately prints exceptions and assertion failures during testing, with diagnostics.
GNU Lesser General Public License v3.0
47 stars 8 forks source link

Add PHP version constraint to Composer #10

Closed peter279k closed 6 years ago

peter279k commented 6 years ago

It's just for this issue.

codecov-io commented 6 years ago

Codecov Report

Merging #10 into master will increase coverage by 32.23%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             master      #10       +/-   ##
=============================================
+ Coverage     51.09%   83.33%   +32.23%     
  Complexity       32       32               
=============================================
  Files             4        4               
  Lines           137       84       -53     
=============================================
  Hits             70       70               
+ Misses           67       14       -53
Impacted Files Coverage Δ Complexity Δ
src/PhpUnit5Printer.php 0% <0%> (ø) 5% <0%> (ø) :arrow_down:
src/Printer.php 98.24% <0%> (+33.12%) 22% <0%> (ø) :arrow_down:
src/PhpUnit6Printer.php 100% <0%> (+43.47%) 5% <0%> (ø) :arrow_down:
src/ImmediateExceptionPrinter.php 100% <0%> (+80%) 0% <0%> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update df2b810...5d74d9d. Read the comment docs.

Bilge commented 6 years ago

As I just proved in #11, these changes do not improve coverage. The coverage issue that used to exist has since been fixed by external changes in PHPUnit, Codecov or something else. The only change I'd be willing to merge here is the PHP version constraint in Composer.