Closed oshdev closed 6 years ago
Dumping a PR in this state isn't particularly helpful. If you don't intend to work on it then I should just close it.
If you do intend to work on it then the PR needs some commentary on the challenges faced supporting PHPUnit 7 and how this PR addresses them.
Hey, I know that some of the changes from this PR are not acceptable for this repo. There's also no tests fix. However the solution does (seem to) work, so feel free to cherry pick it from this if you like. Unfortunately I don't have time right now and I don't expect any time soon to be able to amend the changes to be universal and even more so to fix the tests. Best regards.