search

ScriptFUSION / Porter

:lipstick: Durable and asynchronous data imports for consuming data at scale and publishing testable SDKs.
GNU Lesser General Public License v3.0
611 stars 24 forks source link

Added provider fetch exception handler to ImportConnector #49

Closed Bilge closed 6 years ago

Bilge commented 6 years ago

Since connectors now wrap their fetch code in an error trapping block (using ConnectionContext::retry), resources no longer have the option of catching low level connector exceptions themselves (they are intercepted by the fetch exception handler). However, resources need a way to determine if a recoverable exception should be promoted to fatal, or receive other special handling, so they now have the option of specifying a provider fetch exception handler, which is executed before the user-defined fetch exception handler set in the ImportSpecification.

codecov-io commented 6 years ago

Codecov Report

Merging #49 into 4.0 will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##            4.0    #49   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files        29     29           
  Lines       327    335    +8     
===================================
+ Hits        327    335    +8
Impacted Files Coverage Δ
src/Connector/ImportConnector.php 100% <100%> (ø) :arrow_up:
src/Connector/ConnectionContext.php 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 91ecee9...c660577. Read the comment docs.