codecov-io
commented
5 years ago Codecov Report
Merging #63 into master will not change coverage. The diff coverage is
100%.
@@ Coverage Diff @@
## master #63 +/- ##
=======================================
Coverage 100% 100%
+ Complexity 231 217 -14
=======================================
Files 38 36 -2
Lines 476 447 -29
=======================================
- Hits 476 447 -29| Impacted Files | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| src/Porter.php | 100% <ø> (ø) |
37 <0> (-4) |
:arrow_down: |
| src/Provider/Resource/StaticResource.php | 100% <100%> (ø) |
3 <1> (ø) |
:arrow_down: |
| src/Connector/ImportConnector.php | 100% <100%> (ø) |
29 <2> (ø) |
:arrow_down: |
| src/Connector/NullConnector.php | 100% <100%> (ø) |
1 <1> (ø) |
:arrow_down: |
| src/Connector/CachingConnector.php | 100% <100%> (ø) |
9 <3> (-2) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 6e8bf1e...fd79d5a. Read the comment docs.
ConnectorOptionsandEncapsulatedOptions.CacheKeyGenerator.Since we no longer generate cache keys, but rely on Connectors to generate hash codes that are used as the cache key, we no longer need a
CacheKeyGenerator. However, some users may require some sort of cache key filter to modify the hash before it's stored in the cache; for example, to namespace cache keys. This PR makes no attempt to provide such a replacement but such facility can be added fairly trivially if the need arises.Closes #62.