search

ScriptFUSION / Porter

:lipstick: Durable and asynchronous data imports for consuming data at scale and publishing testable SDKs.
GNU Lesser General Public License v3.0
611 stars 24 forks source link

Prevented single record resources being imported with multi-record import methods #66

Closed Bilge closed 5 years ago

Bilge commented 5 years ago

Continuation of #65.

It is not useful to have a marker interface for single record resources that is only required by importOne()/importOneAsync() because one can just mark all resources as single record and they now work with all import methods, thus obviating its usefulness. By rejecting single record resources from import()/importAsync(), the interface now has the useful purpose of ensuring the correct method is called for single and multi-record resources respectively.

codecov-io commented 5 years ago

Codecov Report

Merging #66 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master    #66   +/-   ##
=======================================
  Coverage       100%   100%           
- Complexity      219    224    +5     
=======================================
  Files            37     37           
  Lines           447    456    +9     
=======================================
+ Hits            447    456    +9
Impacted Files Coverage Δ Complexity Δ
src/Porter.php 100% <100%> (ø) 42 <8> (+2) :arrow_up:
src/IncompatibleResourceException.php 100% <100%> (ø) 4 <4> (+3) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d39c321...2ae2ffb. Read the comment docs.