Scripta-Qumranica-Electronica / ScrollEditor

The Virtual Scroll Editor website
MIT License
3 stars 1 forks source link

Adjust Image tool #119

Open OritandJoe opened 3 years ago

OritandJoe commented 3 years ago
  1. Adjust image should require at least one option marked
  2. Color, Infrared, Left Raking Light , Right Raking Light (enlarge popup box to fit full text)
  3. Make slide bars equal
Bronson-Brown-deVost commented 3 years ago

@zmbq I think all these points sound good.

On point 2, Left Raking Light, Right Raking Light are quite long. Can we shorten those? On the other hand, we may in the future add more images of various types (even types that we don't know of right now). Should we perhaps rethink the labels accordingly? Maybe we could have a "short title" in the interface and then show the "long title" on hover?

OritandJoe commented 3 years ago

Like the hover idea. Perhaps: Color NIR (Near Infra Red) LRL (Left Raking Light) RRL (Right Raking Light)

zmbq commented 2 years ago

1 has already been taken care of. The rest still need to be done.

zmbq commented 2 years ago

Handled issue 3. Issue 2 needs to be handled in the backend - the name is not handled by the frontend - but is displayed as is.

I would not make it longer at all, at most add a space: "raking left", "raking right".

Bronson-Brown-deVost commented 2 years ago

Bronson: add two fields to the DTO, a short name (NIR, LLR) and a long name (Near Infra Red, etc.)