Tests - Githubissues

Scripta-Qumranica-Electronica / Scrollery-website

SQE website

MIT License

3 stars 2 forks source link

Tests #50

Closed sjones6 closed 6 years ago

sjones6 commented 6 years ago

Another round of tests and other minor changes (all misc. formatting changes made by Prettier)

Bronson-Brown-deVost commented 6 years ago

Any idea what is causing travis to fail this?

sjones6 commented 6 years ago

@Bronson-Brown-deVost : The menu changes were minimal just to avoid making an AJAX request that was causing a console error on running tests. I won't be making any more changes so as to not merge conflict your work.

sjones6 commented 6 years ago

Most recent build failure seems related to something in Firefox ... not sure what that's about just now. The previous mistake was something silly.

sjones6 commented 6 years ago

@Bronson-Brown-deVost : here's an interesting one ... Promise.prototype.finally is implemented in Firefox 58, and Travis runs Firefox 56. Hence why I wasn't getting errors locally: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally

sjones6 commented 6 years ago

There's trouble in the Potrace tests. I don't know what's going on there enough to be able to say. @Bronson-Brown-deVost , could ways we could go here:

istanbul ignore that file and delete tests, akin to how we handled the string diff library I pulled in
you could check-out my branch and patch those up?

My latest push skips the two failing test cases.

coveralls commented 6 years ago

Coverage increased (+2.2%) to 82.53% when pulling 62e4c58b769a74c9c38e06fd1352e43aac4b4d40 on tests into 364c400eb44f46576895841d49707598227a7ba7 on master.