Closed Bronson-Brown-deVost closed 6 years ago
@sjones6 I think this should get a review and hopefully a pull to master. I was not yet able to finish renaming of scrolls/cols/artefacts yet, but can probably finish that in another branch Saturday. I also have not put the finishing touches on add new (artefact/col). I can probably get the add new artefact done in another branch tomorrow.
I have added a bunch more tests (especially with the corpus model factory), including 22 server tests now. We dropped a bit in coverage with this branch, but still over 85%, so we should probably just let it go. I am not sure that I have time before July 1 to write any more tests, but perhaps some of yours will push us back up a little (I will try to write a couple more on Saturday). Perhaps you can flesh out the server tests related to signs? If not, I will work on it after the weekend.
I bumped up the coverage with a few more tests (and ignores on the axios parts of my data models). I push this through now as 0.2.0 since it has the new interface.
@sjones6 I agree on setting the coverage bar back down to 85% to get us through these latest changes (perhaps we can continue to move upward though). Any idea why I cannot merge this? All checks pass and changes are approved, but "Merge pull request" is greyed out and it says "Required statuses must pass before merging".
@Bronson-Brown-deVost : I think it is at 85% now, so not sure why it would be failing. I've just updated it so that if it falls by 5% or more in coverage or below 85%, then it will fail ... before we didn't have the 5% bit so maybe that will help.
Almost ready here, just a few more unit tests later today I think. Perhaps I add a few more server unit tests too.