search

Scripta-Qumranica-Electronica / Scrollery-website

SQE website
MIT License
3 stars 2 forks source link

Updated docs, fixed one CGI function. #81

Closed Bronson-Brown-deVost closed 6 years ago

Bronson-Brown-deVost commented 6 years ago

This is just a little bump to stick the updated documentation into the master branch. The docs still need more work, but no need to wait longer now. I also updated one CGI function, which I noticed while writing the docs.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 88.022% when pulling c481cc41d3cdf60d951c3006f6225cb5e4cf1d87 on updated-docs into f03f28dcb1661f4427e9f0c3ff74ccdebbea9424 on master.

Bronson-Brown-deVost commented 6 years ago

@sjones6 Just a heads up. List.js seems to fail in unit testing from time to time. Maybe faker in the object factory gives incompatible values?

Also, amazing that coverage went down 0.02%. This could be due to floating point imprecision, since nothing at all relevant for unit tests was changed. Is it possible that coveralls is counting the lines in scrollery-cgi.pl towards code coverage? I added one line in that file, and I could image that the addition of a single line would result in a 0.02 drop in coverage. If so, can we make sure that coveralls ignores the resources folder completely?

sjones6 commented 6 years ago

Thanks for getting this back in the game.

I didn't think that it detected anything but JS. I'll try to take a look.

sjones6 commented 6 years ago

Going to merge this in as I'm about to do a mega merge that I suspect will be a bit painful.