search

Scripta-Qumranica-Electronica / Scrollery-website

SQE website
MIT License
3 stars 2 forks source link

Add comments #87

Closed Bronson-Brown-deVost closed 6 years ago

Bronson-Brown-deVost commented 6 years ago

This is nearly ready for a pull. We need to fix a bug with adding comments, and existing comments still need to be displayed.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-2.0%) to 78.678% when pulling 9fc4fe1446a33612cb4f7b8e83e4575f65e195c5 on add-comments into b4ba6ab5dd45e7a0f1abc0abc352d41a37238312 on master.

Bronson-Brown-deVost commented 6 years ago

Comment system is working. There are a number of unpleasant UI things going on, especially in the editor side of things. I am refreshing the whole column too often, when really the changes should be made incrementally in the models, but I don't have time to fix now. We do not have adding of columns to scrolls (though the UI is nearly done for that) and we do not have real adding of new lines in the transcriptions (I am still not up to speed on contenteditable and Spencer's use of that to catch input and update data models client and server side). Sometimes menus need to be refreshed if added data do not appear in them. There is a bug with the single image viewer, where it sometimes get's stuck and the website needs to be refreshed before the mask toggle switch will work.