Convert to WebSocket - Githubissues

ScriptaGames / zorbio

A 3D multiplayer WebGL game

MIT License

8 stars 1 forks source link

Convert to WebSocket #242

Closed Jared-Sprague closed 8 years ago

Jared-Sprague commented 8 years ago

After doing performance tests it's clear that WebSocket has a performance advantage over Socket.io, see #157.

Convert Network.js and server.js to use WebSocket

Jared-Sprague commented 8 years ago

Here are the messages. Client on:

welcome
gameSetup
playerJoin
au
foodCaptureComplete
kick
removePlayer
connect
disconnect
connect_failed
serverTick
processingPlayerCapture
invalidCaptureTargetNotInModel
invalidCaptureTargetToFar
speedingWarning
successfulCapture
youDied
playerDied
zorServerPong

Client.emit:

gotit
respawn
pp
playerCapture
continuePlayerCapture
zorServerPing

Server.on:

error
disconnect

Jared-Sprague commented 8 years ago

Pre-requisite #245

mwcz commented 8 years ago

Just found this tool called artillery. Maybe you found it before but just in case:

https://github.com/shoreditch-ops/artillery

It's a node-based load tester for http and ws. We could add it as a dev dependency and add a npm run load to test load stats every time we make a server change! Cool to think about.

Jared-Sprague commented 8 years ago

That sounds cool!

Jared-Sprague commented 8 years ago

@mwcz so after your review, is this ready to merge?

mwcz commented 8 years ago

@Jared-Sprague yep! Everything looked great to me and I couldn't find any bugs.

Jared-Sprague commented 8 years ago

@mwcz Thanks for the review! Merged and closed!