Make the CI green again

ScriptedAlchemy / redux-first-router

🎖 seamless redux-first routing -- just dispatch actions

MIT License

5 stars 2 forks source link

Make the CI green again #23

Closed hedgepigdaniel closed 6 years ago

hedgepigdaniel commented 6 years ago

Prettier must pass everywhere (yarn run prettify or yarn run lint --fix will always fix it)
Eslint must pass in the boilerplate. There is quite a bit more work to be done in the rudy package to make it pass.
Tests must pass
Snyk must pass
The build (as in, yarn run build) must complete in all packages

The import/no-unresolved eslint rule behaved differently on the CI server to my local setup - it originally passed for me.

hedgepigdaniel commented 6 years ago

Seems like travis runs the build and it passes, but then it doesn't report the result and the log is empty.

I know because if you cancel the build in the Travis UI, you can see the log (which shows that the script succeeded). Cancelling it makes it fail though :(

wut

hedgepigdaniel commented 6 years ago

hooray it passed!