search

Scriptor / pharen

Lisp to PHP Compiler
http://pharen.org
BSD 3-Clause "New" or "Revised" License
218 stars 31 forks source link

Interfaces, Inheritance and function prototypes... #16

Closed sandbender closed 11 years ago

sandbender commented 13 years ago

Heya - hope I made these mods more or less correctly... I spent a bunch of time reading through the codebase to try and attack the problem properly :)

Anyways... this stuff works as far as I can tell - I added it because I need it for something I'm writing, DSL for an in-house php framework, I'm implementing it with pharen (thank you!)... so I'm actually using the features already and as far as I can tell this works.

I'll add some UT for this shortly assuming I have time, so watch for another pull request for that...

Lastly - I came across a couple (very small) bugs/mis-configurations in the existing tests when I was running them/starting to add my own... would you prefer I email/message you the details, or is it best if I can just fix them myself and send them in another pull request? Let me know... and once again thanks for pharen :D

Cheers, -Rudy

Scriptor commented 13 years ago

Thanks Rudy!

First, could you provide some examples of what the code for the new features looks like? I've had an idea of how to implement inheritance and interface-implementing so I might have some suggestions. Also, awesome that you're using this for work! I think this is the first official case of someone using it in production.

Just do whatever is easier for you, though submitting a bug report will help keep it in the record I guess. The testing system in general needs to be more fleshed out since it's pretty barebones right now. Also, we can discuss any changes more quickly if you get on the IRC channel (#pharen on Freenode).

Thanks again!

francescoagati commented 13 years ago

there are news on this inclusion? It is really interesting

sandbender commented 13 years ago

Hi francescoagati - I've been busy with work related items lately but I've been in contact with Scriptor and just need a bit of time to squeeze out the agreed changes... the same functionality should be available, but the implementation in this pull request will actually be changed before being merged... main point is the syntax/conventions will likely change a bit before being included (compared to what I've done here), so you might want to wait for the main merge in the interest of backwards-compatibility, etc.

Scriptor commented 11 years ago

Closing for now.