search

Scriptor / pharen

Lisp to PHP Compiler
http://pharen.org
BSD 3-Clause "New" or "Revised" License
218 stars 31 forks source link

Removed compiled PHN files from repo #28

Closed rgantt closed 13 years ago

rgantt commented 13 years ago

Hey Scriptor,

I've been tinkering around in Pharen, and realized that you are including all of your compiled PHN files in the lib directory. I propose that these be removed.

The primary reason I propose this is because the compiled versions contain include paths that are specific to your development machine. I had to recompile them to work in my environment. So, they'll need to be compiled on the end user's machine anyway.

The file lang.php in the project root, although it seems to be compiled from lang.phn, doesn't seem to have any path issues, so I left that one in my commit.

Let me know what you think!

Scriptor commented 13 years ago

Hey Ryan,

Thanks for the code! I'll be working these in later tonight since this points out a deeper flaw in Pharen currently. Basically, the files in lib/ represent something like a standard library for Pharen. This means that parts of the code assume that these files are already compiled to PHP files and available to be included.

This raises a bit of a chicken-and-egg issue, since while just getting Phake set up and doing phake build would resolve this issue, Phake itself relies on the path library in lib/path.phn to be compiled and ready. Since the path issues seem to come from trying to include lang.php I'll have to see if there is a way to include it with relative paths, or find some other solution.

rgantt commented 13 years ago

I assumed that--given the age of this project--you weren't simply leaving these files in out of laziness or something else. Hopefully there's a good way we can get this bootstrapped! I originally opened this pull request just to remove the compiled files.

The other two commits I think would be quick fixes, but yes, I think they are symptoms of suboptimal things elsewhere.