search

ScudLee / anime-lists

147 stars 104 forks source link

Fate/Kaleid Liner mappings #292

Closed evolsano closed 5 years ago

evolsano commented 5 years ago

Not sure is this the correct syntax, but these are my fixed for Fate/Kaleid Liner series.

sixtenbe commented 5 years ago

For Dia no Ace 2014 you should remove the mapping list and set it to defaulttvdbseason="0". The mapping list in this case will map exactly nothing.

The mapping list you added for: Gekijouban Dungeon ni Deai o Motomeru no wa Machigatte Iru Darouka: Orion no Ya should be removed, as it was already handled by the episode offset

For "Fate/Kaleid Liner Prisma Illya (2014)" I'd prefer if you just set episodeoffset="5" instead of using a mapping list.

evolsano commented 5 years ago

Thank you for your comment. I edited as per your advise. Since I still learning on how to do the mapping, I guess I better remove this pull request to prevent any further confusion.

sixtenbe commented 5 years ago

I see that in the updates you made you added a few more unnecessary mappings, which were already covered. I went ahead and looked over your edits and added them manually and I also checked the entirety of Love Live and Fate/Kaleid to fix all mappings for them.

Love Live needed a bunch of Null mappings to avoid conflicts on implicit mappings of special episodes.

To see how I mapped them check out the two latest commits: a519c95 & 66392ba