search

ScudLee / anime-lists

150 stars 105 forks source link

Issue in the use of "tmdbid" in anime-lists #342

Open EndOfLine369 opened 4 years ago

EndOfLine369 commented 4 years ago

Hi,

Looks like someone has started to put TMDB tv series numbers in this field. TMDB reuses their numbers for both TV entries & Movie entries.

At least both of these entries below have incorrectly been set with TV numbers instead of Movie numbers (don't exist)

[+] AniDBid: 14662, TVDBid: 366334, defaulttvdbseason:    1, offset:   0, TMDBid:   88051, IMDBid: tt10431310, name: Katsute Kami Datta Kemono-tachi e
[+] AniDBid: 14229, TVDBid: 354171, defaulttvdbseason:    1, offset:   0, TMDBid:   83104, IMDBid:  tt8731478, name: Mahou Shoujo Tokushusen Asuka

https://www.themoviedb.org/tv/88051 <- To the Abandoned Sacred Beasts (2019) https://www.themoviedb.org/movie/88051 <- On the Bowery (1957)

https://www.themoviedb.org/tv/83104 <- Magical Girl Spec-Ops Asuka (2019) https:/www.themoviedb.org/movie/83104 <- Horny Lesbians @ Work 3 (2009)

Please review ALL "tmdbid" entries that have been added as its pretty bad that this incorrect update loaded a porn image onto my Plex from this incorrect mapping.

If we are wanting to use "tmdbid" for both TV & Movie numbers, the field text will have to be possibly prefixed with a string of 'tv-'/'movie-' or similiar that all consumers will have to be updated to handle. Or a new entry like "tmdbtvid" that would contain the tv entry numbers while the legacy "tmdbid" field would contain the movie entry numbers.

EndOfLine369 commented 4 years ago

AniDB->TVDB id mapping is also incorrect for anidbid="14662". Should be tvdbid="361714". https://thetvdb.com/series/to-the-abandoned-sacred-beasts

sven-7 commented 4 years ago

I removed the TMDBs in my open commit and fixed the mapping too. As for the larger issue...that's probably best for @ScudLee to chime in in?

EndOfLine369 commented 4 years ago

@sven-7, looks like you have only applied to your local fork. the mapping has yet to be corrected in ScudLee master.

sven-7 commented 4 years ago

It's accounted for in my pull for #341. Nobody has merged it in yet. @slohj ?

EndOfLine369 commented 4 years ago

one more to add to the bad tmdb mapping re https://github.com/ZeroQI/Hama.bundle/issues/415

  <anime anidbid="13945" tvdbid="359274" defaulttvdbseason="1" episodeoffset="" tmdbid="88803" imdbid="">
    <name>Vinland Saga</name>
  </anime>

https://www.themoviedb.org/movie/88803 <-- The Silver Fleet (1943)

reconman commented 4 years ago

One more, https://www.themoviedb.org/tv/85368 (El Melloi II Case Files) vs https://www.themoviedb.org/movie/85368-lesbian-legal-4 Lesbian Legal 4.