Closed lennartkloock closed 10 months ago
Merging #116 (fa5418c) into feature/website (ea2387a) will decrease coverage by
0.15%
. Report is 22 commits behind head on feature/website. The diff coverage is40.00%
.
@@ Coverage Diff @@
## feature/website #116 +/- ##
===================================================
- Coverage 73.97% 73.83% -0.15%
===================================================
Files 220 221 +1
Lines 17538 17608 +70
===================================================
+ Hits 12973 13000 +27
- Misses 4565 4608 +43
Files Changed | Coverage Δ | |
---|---|---|
backend/api/src/api/v1/gql/mod.rs | 81.42% <0.00%> (-18.58%) |
:arrow_down: |
backend/api/src/api/v1/gql/models/stream.rs | 6.66% <6.66%> (ø) |
|
backend/api/src/dataloader/stream.rs | 52.94% <17.64%> (-35.30%) |
:arrow_down: |
backend/api/src/database/user.rs | 89.84% <95.45%> (+1.16%) |
:arrow_up: |
backend/api/src/api/v1/gql/models/user.rs | 75.65% <100.00%> (+0.43%) |
:arrow_up: |
backend/api/src/global/mod.rs | 69.91% <100.00%> (+0.24%) |
:arrow_up: |
We can ignore the audit failure the CVE was dropped today, also LAPIN (the library which is affected, isnt used in my branch anymore since we stopped using RMQ)
Proposed changes
Frontend
Backend
display_color
to useractiveStreamsByUserId
GQL endpoint to fetch all active streams by user id (this may become obsolete with the new data structure soon)Types of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments