Closed lennartkloock closed 10 months ago
While you are fixing the CI, can you move the filters from the docker-push action to the docker-push-approve action?
How can the linting check fail when there were no changes made after it passed?
How can the linting check fail when there were no changes made after it passed?
[warn] .circleci/config.yml
The CI config needs to be reformatted.
Merging #117 (d9a6c57) into main (35068f0) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head d9a6c57 differs from pull request most recent head a6f3dc9. Consider uploading reports for the commit a6f3dc9 to get more accurate results
@@ Coverage Diff @@
## main #117 +/- ##
=======================================
Coverage 73.97% 73.97%
=======================================
Files 220 220
Lines 17538 17538
=======================================
Hits 12973 12973
Misses 4565 4565
Proposed changes
For some reason the official Trivy CircleCI Orb just vanished, and the docs now say to use this one: https://circleci.com/developer/orbs/orb/fifteen5/trivy-orb
:latest
with an explicit hash for the build imageTypes of changes
What types of changes does your code introduce to Scuffle? Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments