ScuffleTV / scuffle

Live streaming platform
https://scuffle.tv
233 stars 26 forks source link

feat: remove binary impl for edge, transcoder, ingest #149

Closed TroyKomodo closed 10 months ago

TroyKomodo commented 10 months ago

Proposed changes

The reasoning behind this is because ideally we should provide a simple way for users to launch all services under a single binary. This change refactors how global state works. Allowing us to change the global state as a trait. This also has the effect of removing code duplication.

Types of changes

What types of changes does your code introduce to Scuffle? Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

Further comments

If this is a relatively large or complex change, you may want to start the discussion by explaining why you chose the solution you did, what alternatives you considered, etc.

lennartkloock commented 10 months ago

Do you plan to use the binary helper for the platform api as well?

TroyKomodo commented 10 months ago

@lennartkloock yeah likely

lennartkloock commented 10 months ago

@lennartkloock yeah likely

In this pr?