Add a new feature which allows for cancel blocking tasks on threads. This allows for long blocking tasks (encoding) to yield back to some checker which unwinds the stack if the task has been aborted. This only works if you call the checker, but for most cases we dont have long running code in C or some other library. So its perfectly fine and fixes a lot of the problems we have with encoding blocking shutdown on tokio::spawn_blocking.
Types of changes
What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply
[x] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation Update (if none of the other choices apply)
Checklist
Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.
Proposed changes
Add a new feature which allows for cancel blocking tasks on threads. This allows for long blocking tasks (encoding) to yield back to some checker which unwinds the stack if the task has been aborted. This only works if you call the checker, but for most cases we dont have long running code in C or some other library. So its perfectly fine and fixes a lot of the problems we have with encoding blocking shutdown on
tokio::spawn_blocking.Types of changes
What types of changes does your code introduce to Scuffle? Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
-/-